Alan Cox wrote:
When checking for the CFA feature set support, ata_id_is_cfa() tests bit 2 in word 82 of the identify data instead the word 83; it also checks the ATA/PI standard support in the word 80 -- which the CompactFlash specification has as reserved, this having no slightest chance to work on CF drives that don't have 0x848A in the word 0. Use instead the usual validity check: word 83 bit 14 must be set, bit 15 cleared.
Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>
NAK please stop mixing corrections with bugs that have been explained.
Huh? You haven't explained anything. Your ATA base explanation is simply not valid in the CF world.
You can't exercise logic in the id_is_cfa check that relies upon the device being CFA, which is what your comment says you are doing.
Otherwise it has no chance to detect a CF drive *following the CF specs* and not having 0x848A in word 0. Please suggest a better solution. Perhaps we could check for word 80 being 0?
MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
