On Tue, 27 Jan 2009 00:09:31 +0400 Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> wrote: > When checking for the CFA feature set support, ata_id_is_cfa() tests bit 2 in > word 82 of the identify data instead the word 83; it also checks the ATA/PI > standard support in the word 80 -- which the CompactFlash specification has > as reserved, this having no slightest chance to work on CF drives that don't > have 0x848A in the word 0. Use instead the usual validity check: word 83 bit > 14 must be set, bit 15 cleared. > > Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> NAK please stop mixing corrections with bugs that have been explained. You can't exercise logic in the id_is_cfa check that relies upon the device being CFA, which is what your comment says you are doing. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
