Alan Cox wrote:
why we have to check for ATA revision prior to that -- unless we're trying to guard against pre ATA-3 values other than 0 or 0xFFFF.
Which we are.
On what grounds? Note that ATA-3 only names 0 and 0xFFFF as inappropriate values.
At the point we first use this function we are poking blindly at a device we have not done any other analysis of.
Do you mean ata_dev_readid()? I'm seeing no issue with checking for ATA version there directly if you insist it should be done.
Alan
MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
