> Jeff, Bart, I've changed my mind about recasting this patch as Alan > has requested, as I do consider it correct now. The version check should > be unnecessary since I'm adding the validity bits check (hte fact that > ata_id_major_complex() is quite cumbesome way of checking the minumum > revision # -- this can be done with a single comparison instead of the > bit scan) If you want to just do a specific check yes. I agree there it would make some sense to have a ata_has_version(ATA_VER_BITFOO); that was a single inline & check for ATA3+ Alan -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
