> > I see nothing guaranteeing atomicity here and I suspect you either need > > locks or (for single processor only) some carefully arranged scheme to > > 'stack' the 8/16bit select status. > I thought ide_port callbacks are serialized by IDE layer. I will use locks, I think. So all your accesses are within the various IDE locks so you never taken an interrupt or timer at the wrong moment. Ok - that should be documented though. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html