Re: [PATCH 7/7] libata: Add 32bit PIO support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > +			pad = cpu_to_le32(ioread32(ap->ioaddr.data_addr));
> > +			memcpy(buf + buflen - slop, &pad, slop);
> > +		} else {
> > +			memcpy(&pad, buf + buflen - slop, slop);
> > +			iowrite32(le32_to_cpu(pad), ap->ioaddr.data_addr);
> 
> Shouldn't the rest of pad be initialised to zero or something before it
> is written?

It really doesn't matter but I suppose it wouldn't do any harm not to
expose 3 random bytes of stack to the io bus.

Alan

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux