Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:
> From: Alan Cox <alan@xxxxxxxxxx>
>
> This matters for some controllers and in one or two cases almost doubles
> PIO performance. Add a bmdma32 operations set we can inherit and activate
> it for some controllers
>
> Signed-off-by: Alan Cox <alan@xxxxxxxxxx>
> ---
[...]
> diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
> index 61b1fb4..5c93377 100644
> --- a/drivers/ata/libata-sff.c
> +++ b/drivers/ata/libata-sff.c
[...]
> + if (unlikely(slop)) {
> + __le32 pad;
> + if (rw == READ) {
> + pad = cpu_to_le32(ioread32(ap->ioaddr.data_addr));
> + memcpy(buf + buflen - slop, &pad, slop);
> + } else {
> + memcpy(&pad, buf + buflen - slop, slop);
> + iowrite32(le32_to_cpu(pad), ap->ioaddr.data_addr);
Shouldn't the rest of pad be initialised to zero or something before it
is written?
Regards,
Elias
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
