From: Brice Goglin <brice@xxxxxxxx> Date: Thu, 16 Oct 2008 08:55:08 +0200 > Dan Williams wrote: > > On Wed, 2008-10-15 at 22:02 -0700, David Miller wrote: > > > >>> drivers/dma/ioat_dca.c: In function 'dca_enabled_in_bios': > >>> drivers/dma/ioat_dca.c:81: error: implicit declaration of function 'cpuid_eax' > >>> drivers/dma/ioat_dca.c: In function 'system_has_dca_enabled': > >>> drivers/dma/ioat_dca.c:91: error: implicit declaration of function 'boot_cpu_has' > >>> drivers/dma/ioat_dca.c:91: error: 'X86_FEATURE_DCA' undeclared (first use in this function) > >>> drivers/dma/ioat_dca.c:91: error: (Each undeclared identifier is reported only once > >>> drivers/dma/ioat_dca.c:91: error: for each function it appears in.) > >>> drivers/dma/ioat_dca.c: In function 'ioat_dca_get_tag': > >>> drivers/dma/ioat_dca.c:190: error: implicit declaration of function 'cpu_physical_id' > >>> > >> Known issue. I tried to ping Jeff Garzik about doing a driver bug fix run in > >> order to fix this, but he hasn't shown any signs of life. > >> > >> So I'll do it myself later tonight. :-/ > >> > >> > > The following seems to fix this up... > > > > ---snip---> > > ixgbe, myri10ge: INTEL_IOATDMA can only be selected when X86=y > > > > There's already a completely different fix queued in netdev patchworks > (for myri10ge only right now, to be duplicated for Intel drivers). The > idea is to stop having almost-unrelated drivers select each other > directly, let people select which drivers they really want, and have > Kconfig handle modules/builtin-stuff correctly. See > http://patchwork.ozlabs.org/patch/4506/ Right, my plan was to duplicate this for the other drivers. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html