[..] >>> Thanks. sr.c just doesn't check whether the drive reports audio play >>> capability or not. It just sets it while ide-cd actually checks for >>> the capability. The drive is not reporting it while it can so ide-cd >>> needs blacklist entry for it. Now that idecd has blacklist entry, all >>> should be fine. Eh... I'm not sure whether we need to update sr to >>> follow what ide-cd is doing or not. >>> >>> Thanks. >> >> Actually, as I already pointed out, I'm not at all happy with blacklisting >> stuff. What sounds more sane to me (and this is only me) would be what sr.c >> does: assume that per se the drive can play audio and try to play it. But how >> many drives are there that cannot play audio, aka, would it be a safe assumption >> to say that their number is so diminishingly small that it would be better to >> announce that a drive can play audio by default and fail graciously in the >> _very_ seldom case it actually cannot ... >> > > Hmm... I don't know. I think the flag indicates whether the drive has > DAC and analog audio output, right? Currently, ide-cd checks the AudioPlay bit advertized in the CD-ROM Capabilities and Mechanical Status Page. > I have quite some SATA drives which > don't have audio output at all. I haven't check what they report on the > mode sense page yet. Eh... well, having the bit set when the drive > doesn't support it doesn't hurt too much (yet). Bartlomiej, what do you > think? -- Regards/Gruss, Boris -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
