Re: Can you please test the attached patch for nv hardreset problem?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Oct 5, 2008 at 1:49 AM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> Hello,
>
> Please verify whether the attached patch fixes all hardreset / probing
> related issues.  The patch is on top of v2.6.27-rc8.  Sorry about all
> the mess but it was quite a confusing problem.  Here's what went down.
>
> * During 2.6.27-rcX, libata switched to prefer hardreset.
>
> * Which broke, generic flavor of sata_nv.  Some sata_nv's fail to
>  bring the link up after hardreset.
>
> * A fix patch went in to disable hardreset for generic flavor.  But it
>  accidentaly disabled hardreset for all flavors.
>
> * Which broke nf2/3 and CK804, because their hotplug interrupt bits
>  never get cleared.  They're apparently cleared by hardreset
>  sequence.
>
> * Another fix patch went in to reinstate nv_hardreset for nf2/3 and
>  CK804.
>
> * Which broke nf2/3, which was because nf2/3's hardreset was broken in
>  different way.
>
> So, to sum up, each generation of sata_nv controllers exhibits
> different hardreset behaviors.
>
> * generic: doesn't work.
>
> * nf2/3: signature D2H Reg FIS delivery doesn't work.
>
> * ck804: works.
>
> So, all three require different treatments to prefer hardreset and any
> solution which didn't do that was broken.  The attached patch should
> solve all the problems.
>
> It was messy but this at least fixes hardreset for all flavors of nv
> controllers, so it will generally improve reliability.
>
> Thanks.
>
> --
> tejun
>

OK, patching the 2.6.26 based on your patch doesn't work properly.  It
works for sata devices but not sata emulated devices (but these do
work with the 2.6.27).
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux