On Sunday 05 October 2008, Elias Oltmanns wrote: > Elias Oltmanns <eo@xxxxxxxxxxxxxx> wrote: > > Elias Oltmanns <eo@xxxxxxxxxxxxxx> wrote: > >> Hi Bart, > >> > >> may I ask you to apply yet another inter-diff? This is in order to > >> address three issues: > >> > >> 1. Make sure that no negative value is being passed to > >> jiffies_to_msecs() in ide_park_show(). > >> 2. Drop the superfluous variable hwif in ide_special_rq(). > >> 3. Skip initialisation of task and tf in ide_special_rq() if we are not > >> handling a (un)park request. > > > > Well, #3 should have been done differently because we donn't want to > > check for REQ_(UN)?PARK_HEADS more often than is necessary. > > While preparing the backport to 2.6.27, it has just occurred to me that > we need to clear the IDE_DFLAG_PARKED flag in ide_disk_pre_reset() > because this flag must not be set after *any* sort of access to the > device. > > So, here is yet another revised version of the inter-diff. Just don't > hurry to apply in case I have an enlightening dream tonight and want to > change something more ;-). > > Regards, > > Elias > > Signed-off-by: Elias Oltmanns <eo@xxxxxxxxxxxxxx> I merged this version into the original patch. [ Since it seems that there were no more enlightening dreams... ;) ] -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
