On Wednesday 08 October 2008, Boris Petkov wrote: > On Wed, Oct 8, 2008 at 5:45 PM, Mark de Wever <koraq@xxxxxxxxx> wrote: > > On Wed, Oct 08, 2008 at 08:33:52AM +0200, Borislav Petkov wrote: > > Hi, > >> Bugger, I should be getting at least warnings when compiling this but I don't. > >> This is because I don't have CONFIG_LBD enabled. However, the %ld and %d > >> format specifiers are also not entirely correct but gcc doesn't warn about them > >> - I guess it checks only size but not signedness... > > > > I guess so too. > > > >> Would you like to redo your patch and add a proper comment ontop? > > > > Here you go. > > > > @Boris do you want to add your Signed-off-by too? > > no, just > > Acked-by: Borislav Petkov <petkovbb@xxxxxxxxx> > > > @Bart please apply this patch. > > > > -- > > Subject: ide-tape: Buildfix when IDETAPE_DEBUG_LOG is set to 1. > > > > The format specifier for rq->sector didn't specify the proper size and > > signedness. Borislav Petkov discovered that the signedness for > > rq->nr_sectors and rq->current_nr_sectors also were incorrect. > > > > Signed-off-by: Mark de Wever <koraq@xxxxxxxxx> applied -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
