Re: [PATCH] sata_mv: enable active LED blink mode for SoC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Frans Pop wrote:
On Monday 08 September 2008, Frans Pop wrote:
On Monday 08 September 2008, Mark Lord wrote:
Frans Pop wrote:
So, IMO it is an improvement, but it is definitely not a fix for
the regression.
With a new copy of hdparm, use "hdparm -Q1 /dev/sd?"
Does that fix your "regression" ?
$ sudo hdparm -Q1 /dev/sda

/dev/sda:
 setting queue_depth to 1
 queue_depth   =  1

Yes, that does result in the original behavior of the led.
(Using version 8.9 of hdparm.)

But that's not new information: we'd already determined some time ago that disabling NCQ "fixed" the problem, both if it is done at runtime and when it is disabled in the driver:
http://www.spinics.net/lists/linux-ide/msg25642.html
http://www.spinics.net/lists/linux-ide/msg25645.html
..

Still, that's proof that there is NO REGRESSION here,
so please stop using that term.

Older kernels had a working LED without NCQ,
and so do newer ones.  No regression.

In the meanwhile, it appears that Saeed is working to determine
for sure that this is a hardware limitation, as it appears to be.

Cheers
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux