Re: sata_inic162x LED enable request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jon,

Are you aware that I had a card that "almost" worked, but
would fail with timeouts under any sort of load?


--- echo6 <echo6_uk@xxxxxxxxx> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hmmm,  thanks Bob, I guess I need to consider what else may be causing
> my system to hang with my setup.
> 
> Jon.
> 
> Bob Stewart wrote:
> > Tejun,
> > 
> > I've been using the new driver to boot my second machine for about 2 weeks,
> > now, as well as having another 200GB disk hanging off it; all without any
> > problems.  Well done!  What I would like to see is the LED enabled
> properly,
> > although the board uses a different header pin for each drive.  Anyway, if
> I've
> > got it right, here is my suggested change.
> > 
> > --- linux-2.6.27-rc5.a/drivers/ata/sata_inic162x.c	2008-08-28
> > 18:52:02.000000000 -0400
> > +++ linux-2.6.27-rc5.b/drivers/ata/sata_inic162x.c	2008-09-01
> > 14:05:24.000000000 -0400
> > @@ -96,6 +96,7 @@
> >  	PORT_SCR		= 0x20,
> >  
> >  	/* HOST_CTL bits */
> > +	HCTL_LEDEN		= (1 << 3),  /* enable LED operation */
> >  	HCTL_IRQOFF		= (1 << 8),  /* global IRQ off */
> >  	HCTL_FTHD0		= (1 << 10), /* fifo threshold 0 */
> >  	HCTL_FTHD1		= (1 << 11), /* fifo threshold 1*/
> > @@ -540,7 +541,7 @@
> >  	void __iomem *port_base = inic_port_base(ap);
> >  
> >  	/* fire up the ADMA engine */
> > -	writew(HCTL_FTHD0, port_base + HOST_CTL);
> > +	writew(HCTL_FTHD0 + HCTL_LEDEN, port_base + HOST_CTL);
> >  	writew(IDMA_CTL_GO, port_base + PORT_IDMA_CTL);
> >  	writeb(0, port_base + PORT_CPB_PTQFIFO);
> > 
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
> 
> iD8DBQFIv43UbSv1saVS9ucRAj4UAJ4q9JvPtY8NqvO8U872pckCgDDTSQCdGUUm
> AhMtUYC7/J7i8Cl/H8CS2rc=
> =bOFu
> -----END PGP SIGNATURE-----
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux