--- Tejun Heo <tj@xxxxxxxxxx> wrote: > > Hmm... according to the datasheet, this is SWLED. > > SOFTWARE CONTROL LED ENABLE: When set, software has full control of > LED activity. When clear, the LEDâ??s are controlled by hardware. > > And then there are two more bits, LED0 and LED1 which seem to be the > actual control knob for LEDs. From the description it looks like the > bit should stay off so tha the controller hardware can drive LEDs. I > presume this doesn't work as described? Uh oh. It sounds like we may not be looking at the same book. The one I have is "INIC-1620TA2/1622TA2/1623TA2", Version 1.4, October, 2005. In this book, the bit is "03 rw 0 (LEDEN) LED ENABLE: When set, the LED will flash when the device is busy." With your driver as-is, both LEDs turn on during the boot process and then stay on completely. Which book are you using and are all these bits in the Global Control register, which we call HOST_CTL? Did I get an old book? > > /* fire up the ADMA engine */ > > - writew(HCTL_FTHD0, port_base + HOST_CTL); > > + writew(HCTL_FTHD0 + HCTL_LEDEN, port_base + HOST_CTL); > > Nitpick: for flags, it's customary to use | instead of +. Oh, duh. <red face> -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
