On Monday 18 August 2008, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Sunday 17 August 2008, Borislav Petkov wrote: > > Hi Bart, > > > > here's something i've been wanting to do for a long time: debugging macros. The > > reason for it is that i got tired of adding debug printk's everytime i'm testing > > something so here we go. > > > > The debugging macro is similar to the old ones but is one for all drivers > > (currently only ide-floppy), is nice on branch prediction and is controlled by a > > drive->debug_mask switch which is a module parameter and as such can be set at > > module load time, of course. I've been thinking of adding also a sysfs attribute > > too but can't seem to find quite the justification for it so no sysfs for now :) > > if you look closely you should already find it :) > > [ module parameters are exported through sysfs and it uses 0644 mask ] Together with sysfs device-driver binding/unbinding support it can probably substitute for lack of sysfs attribute for now. ;) Anyway adding a proper device sysfs attribute will be trivial (ide_dev_attrs[]) but lets wait with it until things settle down. Thanks, Bart -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html