Hi Bart, here's something i've been wanting to do for a long time: debugging macros. The reason for it is that i got tired of adding debug printk's everytime i'm testing something so here we go. The debugging macro is similar to the old ones but is one for all drivers (currently only ide-floppy), is nice on branch prediction and is controlled by a drive->debug_mask switch which is a module parameter and as such can be set at module load time, of course. I've been thinking of adding also a sysfs attribute too but can't seem to find quite the justification for it so no sysfs for now :) In addition, one can still optimize away all the debug calls in the old manner and i'm sure those will be removed completely too when ide generic conversion is done. Please tell me what you think, what can be changed/improved and after we've figured out the details I'll do the other drivers too. Thanks. drivers/ide/ide-cd.c | 17 ++--- drivers/ide/ide-floppy.c | 168 +++++++++++++++++++++++++--------------------- drivers/ide/ide-tape.c | 23 ++---- include/linux/ide.h | 31 ++++++++- 4 files changed, 135 insertions(+), 104 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
