> + static const char command_sect_size[256] = { > + [ ATA_CMD_CFA_TRANSLATE_SECTOR ] = DEVICE, Should be a bit array so we can do a single fast test_bit() > + if (size == UNKNOWN && printk_ratelimit()) > + printk("Unknown ata cmd %d, assuming 512 byte sector size\n", > + command); or two bits ;) Rest looks ok. I'll probably send a follow up patch to make most pata drivers return "no" to anything but 512 until we can test them with real devices. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html