On Tuesday 29 July 2008, Adrian Bunk wrote: > On Sun, Jul 27, 2008 at 04:32:16PM +0200, Bartlomiej Zolnierkiewicz wrote: > > On Sunday 27 July 2008, Adrian Bunk wrote: > >... > > > <-- snip --> > > > > > > Considering the little benefits of all this fiddling with IDE_MAX_HWIFS > > > I decided to fix it through a simplification: > > > - always #define MAX_HWIFS CONFIG_IDE_MAX_HWIFS > > > - always set CONFIG_IDE_MAX_HWIFS in kconfig > > > - let IDE_MAX_HWIFS default to 10 > > > - allow changing the value of IDE_MAX_HWIFS only if IDE && EMBEDDED > > > > I was actually wondering whether it is worth to keep IDE_MAX_HWIFS > > now that ide_hwif_t instances are allocated dynamically. > > > > [ The difference between MAX_HWIFS == 10 and MAX_HWIFS == 2 is now > > ~100 bytes (x86_32) and between MAX_HWIFS == 10 and MAX_HWIFS == 1 > > it is ~1kb (IIRC). ] > > > > Since there were also many other improvements in shrinking drivers/ide/ > > code size which should keep embedded users happy and compensate for > > the above 1kB-worst-case I would prefer to have IDE_MAX_HWIFS removed > > completely. > >... > > Patch below. applied Thanks Adrian! -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
