Re: + pata_viac-add-flag-for-vx800-and-add-a-function-for-fixing-internal-bugs-for-via-chipsets.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Alan Cox wrote:
>> And, likewise, I think
>>
>> 	if (tf->ctl != tf->last_ctl)
>> 		tf->flags |= ATA_TFLAG_DEVICE;
>> 	ata_sff_tf_load(ap, tf);
>>
>> would be better.
> 
> Are we actually guranteed that tf->device is valid in every case where
> ATA_TFLAG_DEVICE is not set ? I don't think we actually are, in which
> case we should cache the last tf->device in the ap->private_data
> structures

Yeap, tf->device is setup during ata_tf_init().

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux