Alan Cox wrote: >> And, likewise, I think >> >> if (tf->ctl != tf->last_ctl) >> tf->flags |= ATA_TFLAG_DEVICE; >> ata_sff_tf_load(ap, tf); >> >> would be better. > > Are we actually guranteed that tf->device is valid in every case where > ATA_TFLAG_DEVICE is not set ? I don't think we actually are, in which > case we should cache the last tf->device in the ap->private_data > structures Yeap, tf->device is setup during ata_tf_init(). -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
