The ali_init_one() function does a search for an isa_bridge,
but then fails to release it if the revision information was
not correctly found.
the problem comes from:
isa_bridge = pci_get_device(...);
if (isa_bridge && ...) {
pci_dev_put(isa_bridge);
}
where the pci_dev_put() is never called if isa_bridge
was valid but the extra checks on the chip-revision
fail to match.
Signed-off-by: Ben Dooks <ben-linux@xxxxxxxxx>
Index: linux-2.6.26-quilt4/drivers/ata/pata_ali.c
===================================================================
--- linux-2.6.26-quilt4.orig/drivers/ata/pata_ali.c 2008-07-24 16:26:43.000000000 +0100
+++ linux-2.6.26-quilt4/drivers/ata/pata_ali.c 2008-07-24 16:27:24.000000000 +0100
@@ -550,8 +550,9 @@ static int ali_init_one(struct pci_dev *
pci_read_config_byte(isa_bridge, 0x5E, &tmp);
if ((tmp & 0x1E) == 0x12)
ppi[0] = &info_20_udma;
- pci_dev_put(isa_bridge);
}
+ pci_dev_put(isa_bridge);
+
return ata_pci_sff_init_one(pdev, ppi, &ali_sht, NULL);
}
--
Ben (ben@xxxxxxxxx, http://www.fluff.org/)
'a smiley only costs 4 bytes'
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
