Re: [PATCH] libata: fix out-of-bounds access in pata_oldpiix.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 18 Jul 2008 09:06:12 +0200
David Müller <dave.mueller@xxxxxx> wrote:

> The "pata_oldpiix" driver in linux-2.6.26 is calling its "set_dmamode" 
> routine also locally, but under different preconditions as the 
> corresponding call in libata-core.c. This may cause an "out-of-array 
> bounds" access in "oldpiix_set_dmamode".

This looks wrong adev->dma_mode should never be invalid at this point.
Are you not confusing dma_mask and dma_mode. Can you provide the
backtraces of the failing case and the actual chip variant you are using ?

Either way the fix is not in oldpiix if this is appearing as 0xFF but in
the core code so NAK

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux