Re: [PATCH] palm_bk3710: fix IDECLK period calculation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 08 July 2008, Sergei Shtylyov wrote:
> The driver uses completely bogus rounding formula for calculating period from
> the IDECLK frequency which gives one-off period values (e.g. 11 ns with 100 MHz
> IDECLK) which in turn can lead to overclocked IDE transfer timings.  Actually,
> rounding is just wrong in this case, so use a mere division for a safe result.
> 
> While at it, also:
> 
> - give 'ide_palm_clk' variable a more suitable name;
> 
> - get rid of the useless 'ideclkp' variable;
> 
> - drop the LISP stype 'p' postfix from the 'clkp' variable's name. :-)
> 
> Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>

applied, thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux