On Thursday 17 April 2008, Boris Petkov wrote: > On Thu, Apr 17, 2008 at 1:04 PM, Roel Kluin <12o3l@xxxxxxxxxx> wrote: > > Boris Petkov wrote: > > > > > I'd rather keep the "unsigned long bio_sectors;" part and do something > > > of the likes of: > > > > > > bio_sectors = bio_sectors(failed_command->bio); > > > > > > > > > (remove the "if (bio_sectors < 4)"-test) > > > > > > ... and later... > > > > > > sector &= ~(max(bio_sectors - 1, 3)); drivers/ide/ide-cd.c: In function ‘cdrom_analyze_sense_data’: drivers/ide/ide-cd.c:180: warning: comparison of distinct pointer types lacks a cast [ which actually hints us into real issue -> please think what would happen if bio_sectors() returns _zero_ before and after the patch ] I applied the patch replacing the above code with: bio_sectors = max(bio_sectors(failed_command->bio), 4U); sector &= ~(bio_sectors - 1); Thanks, Bart -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
