Sergei,
On Sun, 27 Apr 2008 00:46:14 +0800
"Sergei Shtylyov" <sshtylyov@xxxxxxxxxxxxx> wrote:
> Re: [PATCH] ata: Add Intel SCH PATA support
>
> Hello.
>
> Alek Du wrote:
>
> > Seems I need to post the patch here instead of LKML
>
> Your patch is whitespace damaged -- all tabs converted to spaces.
>
I forward the patch from LKML and seems my clawsmail client eat all tabs ....
> > [PATCH] ata: Add Intel SCH PATA support
>
> > This patch adds Intel SCH chipsets (US15W, US15L, UL11L) PATA controller
> > support.
>
> > Signed-off-by: Alek Du <alek.du@xxxxxxxxx>
>
> > diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
> > index b7c38ee..7f95a9a 100644
> > --- a/drivers/ata/ata_piix.c
> > +++ b/drivers/ata/ata_piix.c
> > @@ -214,6 +214,8 @@ static const struct pci_device_id piix_pci_tbl[] = {
> > /* ICH7/7-R (i945, i975) UDMA 100*/
> > { 0x8086, 0x27DF, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich_pata_100 },
> > { 0x8086, 0x269E, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich_pata_100 },
> > + /* INTEL SCH UDMA 100 */
> > + { 0x8086, 0x811A, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich_pata_100 },
> > /* ICH8 Mobile PATA Controller */
> > { 0x8086, 0x2850, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich_pata_100 },
> >
> > @@ -561,6 +563,10 @@ struct ich_laptop {
> > u16 subdevice;
> > };
> >
> > +struct sch_80 {
> > + u16 device;
> > +};
> > +
>
> Why create a structure which has only single field?
>
Currently, it only use device ID to decide if force to go SCH way (force
to PATA_80 and skip port enabling bit check), but it would be easier for expanding
if I define a structure here. (looks like ich_laptop)
> MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
