On Mon, Apr 14, 2008 at 05:16:59PM +0300, Adrian Bunk wrote: > It's plain wrong for PCMCIA to select HAVE_IDE that implies e.g. the > availability of an asm/ide.h > > Signed-off-by: Adrian Bunk <bunk@xxxxxxxxxx> > > --- > 9cdb66112488bc0c6e1d528444d3ba30d5b0487f diff --git a/drivers/pcmcia/Kconfig b/drivers/pcmcia/Kconfig > index 8b22281..519b4ff 100644 > --- a/drivers/pcmcia/Kconfig > +++ b/drivers/pcmcia/Kconfig > @@ -38,7 +38,6 @@ config PCMCIA_DEBUG > config PCMCIA > tristate "16-bit PCMCIA support" > select CRC32 > - select HAVE_IDE > default y I did this when introducing HAVE_IDE. But I do not recall why and the rationale for removing it seems fine to me. So patch looks good - but I have not investigated in detail. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
