Hello, James. On Sun, 2008-04-13 at 17:36 -0500, James Bottomley wrote: > On Sun, 2008-04-13 at 17:19 -0500, James Bottomley wrote: > > This patch: > > > > commit 6856ebbf3e46c8184cec15f59d6436692f85d8ba > > Author: Tejun Heo <htejun@xxxxxxxxx> > > Date: Mon Apr 7 22:47:20 2008 +0900 > > > > libata: replace tf_read with qc_fill_rtf for non-SFF drivers > > > > Takes away our libsas port_ops->sff_tf_read > > > > However, as soon as we get into atapi_request_sense() we hit > > > > #ifdef CONFIG_ATA_SFF > > ap->ops->sff_tf_read(ap, &qc->tf); > > #endif > > > > And panic. > > > > atapi_request_sense seems to be unavoidable if we hit an AC_ERR_DEV in > > atapi_qc_complete > > > > How is this supposed to work? Ah.. Right. I forgot sas was non-SFF + old EH there. > This is the patch that fixes the panic for me. It looks like this was > just an oversight in the conversion to qc_fill_rtf. > > James > > --- > > diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c > index b195d82..8b72c64 100644 > --- a/drivers/ata/libata-scsi.c > +++ b/drivers/ata/libata-scsi.c > @@ -2390,9 +2390,7 @@ static void atapi_request_sense(struct ata_queued_cmd *qc) > /* FIXME: is this needed? */ > memset(cmd->sense_buffer, 0, SCSI_SENSE_BUFFERSIZE); > > -#ifdef CONFIG_ATA_SFF > - ap->ops->sff_tf_read(ap, &qc->tf); > -#endif > + ap->ops->qc_fill_rtf(qc); > > /* fill these in, for the case where they are -not- overwritten */ > cmd->sense_buffer[0] = 0x70; > I think what's more appropriate is to just add if (ap->ops->sff_tf_read) on top of it or just kill it altogether. TF is already read when the original command failed with CHECK SENSE. Will send a patch. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
