Hi, On Wednesday 09 April 2008, Richard Zidlicky wrote: > On Wed, Apr 09, 2008 at 03:40:34AM +0200, Michael Schmitz wrote: > > > > However, not only FS data is byteswapped, complete disk including partition > > > table and everything else is. Will "rq->cmd_type == REQ_TYPE_FS" also catch > > > all these cases? > > > > IIRC only identify data (and perhaps ATAPI data) need to be byteswapped > > twice (or not at all), so REQ_TYPE_FS should catch all other cases. > > my main worry is whether REQ_TYPE_FS is set even when using raw disk access, > eg reading partition table or raw partitions. AFAIK direct I/O is also handled by REQ_TYPE_FS requests so it should be fine. Only special commands (identify, S.M.A.R.T., raw commands passed through taskfile ioctl) should be byte-swapped. I just merged the patch into IDE tree (together with few other changes) so some testing would be greatly appreciated. Thanks, Bart -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
