Re: [PATCH #upstream 1/3] libata/pdc_adma: make SFF EH handle non-bmdma SFF drivers and standardize pdc_adma ops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tejun Heo wrote:
pdc_adma has interface similar to SFF but has its own DMA interface.
It currently implements noop bmdma ops to avoid crashing
ata_bmdma_error_handler() which BTW actually is EH for SFF drivers.

This patch makes ata_bmdma_error_handler() dereference bmdma ops iff
bmdma_addr is initialized as done in ata_bmdma_post_internal_cmd.
This change allows pdc_adma to standardize ops and use SFF
error_handler and post_internal_cmd.

Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
Cc: Mark Lord <liml@xxxxxx>
---
This patch series in on top of #cleanup-sht-ops (ed75ba53) and not for
#upstream-fixes.  Tested with pdc_adma controllers Mark sent me. :-)

 drivers/ata/libata-sff.c |    3 ++-
 drivers/ata/pdc_adma.c   |   16 ++--------------
 2 files changed, 4 insertions(+), 15 deletions(-)

applied 1-3

I realize now that the lack of this patchset (broken ordering on my part) probably caused the previously-emailed-about compile breakage. sorry! I'll pull the rest after a resync, since I ack'd that 27-patch patchset.


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux