Tejun Heo wrote:
When errors occur during flush, instead of writing out the rest and reporting the errors, ATA halts the processing and report the error, so FLUSH must be retried on failure. Also, the spec says that FLUSH may take more than 30 secs but doesn't mention anything about the actual limit. This patch improves FLUSH error handling such that... 1. It's always retried with longer timeout (60s for now) after failure. 2. If the device is making progress by retrying, humor it for longer (20 tries for now). 3. If the device is fails the command with the same failed sector, retry fewer times (log2 of the original number of tries). 4. If retried FLUSH fails for something other than device error, don't keep retrying. We're likely wasting time. This patch is inspired by Alan's patch to improve ata_flush_cache(). Signed-off-by: Tejun Heo <htejun@xxxxxxxxx> Cc: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> --- drivers/ata/libata-eh.c | 131 ++++++++++++++++++++++++++++++++++++++++++++++- include/linux/libata.h | 5 ++- 2 files changed, 134 insertions(+), 2 deletions(-)
I didn't apply this, because it seemed like it was still under discussion a bit.
People are talking in the right direction, so I'm likely to apply whatever the end result is, it sounds like
-- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
