For ADMA, I lean to disable it for default because stability is more important to our customers. At least, bug in this link: http://www.gossamer-threads.com/lists/linux/kernel/885929 is not resolved. Best regards, Kuan Luo > -----Original Message----- > From: Tejun Heo [mailto:htejun@xxxxxxxxx] > Sent: Sunday, March 30, 2008 8:12 AM > To: Zoltan Boszormenyi > Cc: akpm@xxxxxxxxxxxxxxxxxxxx; jeff@xxxxxxxxxx; > linux-ide@xxxxxxxxxxxxxxx; hancockr@xxxxxxx; Kuan Luo; Peer Chen > Subject: Re: [patch 3/3] ata: SWNCQ should be enabled by default > > Zoltan Boszormenyi wrote: > > Tejun Heo írta: > >> akpm@xxxxxxxxxxxxxxxxxxxx wrote: > >>> From: Zoltan Boszormenyi <zboszor@xxxxxxxxxx> > >>> > >>> unchangelogged patch. > >>> > >>> Signed-off-by: Zoltan Boszormenyi <zboszor@xxxxxxxxxx> > >>> Cc: Robert Hancock <hancockr@xxxxxxx> > >>> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > >> > >> Nacked-by: Tejun Heo <htejun@xxxxxxxxx> > >> > >> Sorry, there are remaining issues to resolve before > enabling ADMA by > >> default. > > > > Sorry, this is NOT ADMA. SWNCQ is completely independent from ADMA. > > Heh, right. Sorry about that. I disabled ADMA on the distro > I work for > and somehow ADMA was disabled on mainline too. :-) > > Robert, is SWNCQ safe to turn on by default? I personally think it's > better to prefer safety over performance or optional features > and given > the history of NCQ support on nv satas, I feel a bit more cautious. > > Maybe we can enable SWNCQ on -mm and devel branches and > disable it late > in release cycle for 2.6.26 for a trial? > > Kuan Luo and Peer Chen, what do you guys think about this? > And can you > guys please find a way to assist Robert in fixing the ADMA problems? > For 2.6.25, we're too late to disable it. For 2.6.26, I'm afraid we > will have to disable it unless those known issues are solved. :-( > > Thanks. > > -- > tejun > ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
