> Are we sure that it is ever the right thing to do to reissue a flush command? The spec is pretty clear about this. > I am worried that this might be much closer to the media error class of device > errors than something that will benefit from a retry of any type. There are several cases it matters and there are some where it is going to matter. RAID firmware is the obvious one but the upcoming joy is large physical sector sizes where a read/modify/write may be required and fail but the remaining sectors can be written or fired at spare blocks > Also, I am unclear as to how we measure the progress of the device if the flush > command has failed? The spec says that if a flush fails to write back a block then the failed block is dropped from the cache. Thus you make progress and you have a mechanism to report each failed LBA. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
