Jeff Garzik wrote: > Tejun Heo wrote: >> PCI device should be powered up or powered up before its PCI regsiters >> are accessed. Although PCI configuration register access is allowed >> in D3hot, PCI device is free to reset its status when transiting from >> D3hot to D0 causing configuration data to change. >> >> Many libata SFF drivers which use ata_pci_init_one() read and update >> configuration registers before calling ata_pci_init_one() which >> enables the PCI device. Also, in resume paths, some drivers access >> registers without resuming the PCI device. >> >> This patch adds a call to pcim_enable_device() in init path if >> register is accessed before calling ata_pci_init_one() and make resume >> paths first resume PCI devices, access PCI configuration regiters then >> resume ATA host. >> >> While at it... >> >> * cmd640 was strange in that it set ->resume even when CONFIG_PM is >> not. This is by-product of minimal build fix. Updated. >> >> * In cs5530, Don't BUG() on reinit failure. Just whine and fail >> resume. >> >> Signed-off-by: Tejun Heo <htejun@xxxxxxxxx> >> --- >> drivers/ata/pata_ali.c | 14 +++++++++++++- >> drivers/ata/pata_amd.c | 16 +++++++++++++++- >> drivers/ata/pata_artop.c | 5 +++++ >> drivers/ata/pata_cmd640.c | 21 ++++++++++++++++----- >> drivers/ata/pata_cmd64x.c | 15 ++++++++++++++- >> drivers/ata/pata_cs5520.c | 15 ++++++++++++++- >> drivers/ata/pata_cs5530.c | 18 ++++++++++++++++-- >> drivers/ata/pata_hpt366.c | 14 +++++++++++++- >> drivers/ata/pata_hpt37x.c | 5 +++++ >> drivers/ata/pata_hpt3x2n.c | 5 +++++ >> drivers/ata/pata_it821x.c | 14 +++++++++++++- >> drivers/ata/pata_netcell.c | 5 +++++ >> drivers/ata/pata_ns87415.c | 6 ++++++ >> drivers/ata/pata_optidma.c | 5 +++++ >> drivers/ata/pata_serverworks.c | 19 ++++++++++++++++--- >> drivers/ata/pata_sil680.c | 13 +++++++++++-- >> drivers/ata/pata_sis.c | 6 +++++- >> drivers/ata/pata_sl82c105.c | 5 +++++ >> drivers/ata/pata_via.c | 14 +++++++++++++- >> 19 files changed, 195 insertions(+), 20 deletions(-) > > Did Alan ACK this? ISTR he did. Alan? > Can this wait until 2.6.26, or is it important for 2.6.25? We've been okay till now. I don't think it's pressing enough to push this for 2.6.25 at this point. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
