On Thu, 13 Mar 2008, FUJITA Tomonori wrote: > On Thu, 13 Mar 2008 09:03:26 +0900 > FUJITA Tomonori <tomof@xxxxxxx> wrote: > > > > There are two problems. One is the types of the arguments and return > > > value. > > > > They should be ok with the updated patch. > > > > > > > The other is that local interrupts need to be disabled. > > > > Can you disable local interrupts here? > > I meant, are you fine with disabling local interrupts here? > > If you don't like that, we need to add another argument and seveal > 'if' to sg_copy_buffer. But I prefer to keep it simple. Disabling local interrupts in usb_stor_access_xfer_buf() is okay. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html