On Wednesday 12 March 2008, Borislav Petkov wrote: > > > The remaining pipeline stage allocation code is used for the next current > > > pipeline stage (tape->merge_stage) and data buffer for an upcoming > > > request. The so allocated pipeline stage is rewired into the tape struct > > > thru idetape_switch_buffers() and used during the next request for > > > copying user data into it (see e.g. idetape_chrdev_write()). In case the > > > allocation fails, the current request is still attempted prior to failing. > > > > Is this really needed now that we've removed pipeline operation for write > > requests? > > I did this simply to keep behavior changes at minimum - after removing the > pipeline code completely this'll be simplified too. BTW I see now how poorly I explained things the last time. :( [ Sorry for that! ] Our goal is not "pure" minimal behavior changes but minimal "behavior + code" changes - IOW we are searching for the best balance for keeping both the old behavior and code changes (and thus patch _complexity_) at the minimal level. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
