On Tuesday, 11 of March 2008, Tejun Heo wrote:
> pata_ali and pata_it821x were using qc->nbytes to determine whether a
> command is data transfer type or not. As now qc->nbytes can be
> extended by padding and draining buffers, this tests are not useful
> anymore. Use atapi_cmd_type() instead.
>
> Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
> Cc: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
> Cc: Rafael J. Wysocki <rjw@xxxxxxx>
Tested-by: Rafael J. Wysocki <rjw@xxxxxxx>
> ---
> drivers/ata/pata_ali.c | 2 +-
> drivers/ata/pata_it821x.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/pata_ali.c b/drivers/ata/pata_ali.c
> index 7e68edf..8786455 100644
> --- a/drivers/ata/pata_ali.c
> +++ b/drivers/ata/pata_ali.c
> @@ -295,7 +295,7 @@ static void ali_lock_sectors(struct ata_device *adev)
> static int ali_check_atapi_dma(struct ata_queued_cmd *qc)
> {
> /* If its not a media command, its not worth it */
> - if (qc->nbytes < 2048)
> + if (atapi_cmd_type(qc->cdb[0]) == ATAPI_MISC)
> return -EOPNOTSUPP;
> return 0;
> }
> diff --git a/drivers/ata/pata_it821x.c b/drivers/ata/pata_it821x.c
> index 109ddd4..f751749 100644
> --- a/drivers/ata/pata_it821x.c
> +++ b/drivers/ata/pata_it821x.c
> @@ -564,7 +564,7 @@ static int it821x_check_atapi_dma(struct ata_queued_cmd *qc)
> struct it821x_dev *itdev = ap->private_data;
>
> /* Only use dma for transfers to/from the media. */
> - if (qc->nbytes < 2048)
> + if (atapi_cmd_type(qc->cdb[0]) == ATAPI_MISC)
> return -EOPNOTSUPP;
>
> /* No ATAPI DMA in smart mode */
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
