Bartlomiej Zolnierkiewicz wrote:
On Thursday 06 March 2008, walt wrote:Hi Bartolmiej, For me, this commit causes the problem it's intended to fix: commit 9f10d9ee0ac6d79d7bc8b9a158bf4a29322d84d3 Author: Bartlomiej Zolnierkiewicz<bzolnier@xxxxxxxxx> Date: Tue Feb 26 21:50:35 2008 +0100 ide-cd: fix 'ireason' handling for REQ_TYPE_ATA_PC requests
Does the following patch help? [ Borislav, please take a look and double check that it is OK. ] From: Bartlomiej Zolnierkiewicz<bzolnier@xxxxxxxxx> Subject: [PATCH] ide-cd: mark REQ_TYPE_ATA_PC write requests with REQ_RW flag It turned out that REQ_TYPE_ATA_PC write requests were not marked as such (the previous commit assumed them to be). Reported-by: walt<w41ter@xxxxxxxxx> Cc: Borislav Petkov<petkovbb@xxxxxxxxxxxxxx> Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@xxxxxxxxx> --- drivers/ide/ide-cd_ioctl.c | 4 ++++ 1 file changed, 4 insertions(+) Index: b/drivers/ide/ide-cd_ioctl.c =================================================================== --- a/drivers/ide/ide-cd_ioctl.c +++ b/drivers/ide/ide-cd_ioctl.c @@ -457,6 +457,10 @@ int ide_cdrom_packet(struct cdrom_device layer. the packet must be complete, as we do not touch it at all. */ ide_cd_init_rq(drive,&req); + + if (cgc->data_direction == CGC_DATA_WRITE) + req.cmd_flags |= REQ_RW; + memcpy(req.cmd, cgc->cmd, CDROM_PACKET_SIZE); if (cgc->sense) memset(cgc->sense, 0, sizeof(struct request_sense));
It's perfect, thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
