Mark Lord wrote:
Jeff Garzik wrote:
Mark Lord wrote:
Jeff / Tejun / Alan,
I'm trying to sort out the spinlocks in sata_mv.
In some places, the existing code uses ap->lock.
But in others, notably the interrupt handling, it uses ap->host->lock.
This looks buggy to me, and I'm wondering how to make it bulletproof.
Look closely, there is only one lock. ata_port does not have a
spinlock, just a pointer...
..
Ahh.. in ata_port_alloc(). Thanks.
..
Okay. Does the LLD even need to bother with this lock
in the various pre/soft/hard reset routines ?
I don't think so, but sata_mv currently tries to lock there.
???
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html