On Saturday 01 March 2008, Borislav Petkov wrote: > Also, remove idetape_kmalloc_stage() and idetape_add_stage_tail() since they've > become unused, as a result. I wonder whether some of these changes should be done before patch #2 or #3? It could be that it would make patches #2-4 obvious, ie. > - if (!test_bit(IDETAPE_FLAG_PIPELINE_ERR, &tape->flags) && > - tape->nr_stages < max_stages) { > - new_stage = idetape_kmalloc_stage(tape); > - while (new_stage != NULL) { > - new_stage->rq = rq; > - idetape_add_stage_tail(drive, new_stage); > - if (tape->nr_stages >= max_stages) > - break; > - new_stage = idetape_kmalloc_stage(tape); > - } > - } I can see now that after this change ->first_stage will be always NULL -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html