[PATCH] scsi: align shost->hostdata to cacheline

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



shost->hostdata can contain arbitrary data including DMA target
buffers.  Align it to cacheline.

Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
---
James, what do you think?

 include/scsi/scsi_host.h |    8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
index 5c58d59..3876d24 100644
--- a/include/scsi/scsi_host.h
+++ b/include/scsi/scsi_host.h
@@ -663,12 +663,10 @@ struct Scsi_Host {
 	void *shost_data;
 
 	/*
-	 * We should ensure that this is aligned, both for better performance
-	 * and also because some compilers (m68k) don't automatically force
-	 * alignment to a long boundary.
+	 * Used for storage of host specific stuff.  As it may contain
+	 * arbitrary data, align it to cacheline.
 	 */
-	unsigned long hostdata[0]  /* Used for storage of host specific stuff */
-		__attribute__ ((aligned (sizeof(unsigned long))));
+	unsigned long hostdata[0] ____cacheline_aligned;
 };
 
 #define		class_to_shost(d)	\
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux