> Needless parens all over the code like this... > Also, you could have made it either 2 (getting rid of |= operator) or 4 > lines (read/write, &=, and |=). mode |= dev << 4; - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html