Re: [PATCH 24/32] ide-tape: remove unreachable code chunk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sunday 27 January 2008, Borislav Petkov wrote:
> From: Borislav Petkov <bbpetkov@xxxxxxxx>
> 
> tape->speed_ctl is set to 1 in idetape_setup(), but, in calculate_speeds() its
> value is tested for being 0, 1, or 2. Remove the if-branches where
> tape->speed_ctl != 1 since they are never executed.
> 
> Also, rename calculate_speeds() by adding driver's prefix as is with the other
> function names.
> 
> Signed-off-by: Borislav Petkov <bbpetkov@xxxxxxxx>

This change is fine but it seems to depend on "ghost" patch #23. ;)

Please move it near the beginning of the series when resubmitting.

Thanks,
Bart
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux