On Sunday 27 January 2008, Borislav Petkov wrote: > Signed-off-by: Borislav Petkov <bbpetkov@xxxxxxxx> applied with some changes > --- > drivers/ide/ide-tape.c | 40 +++++++++++++++------------------------- > 1 files changed, 15 insertions(+), 25 deletions(-) [...] > @@ -3977,7 +3968,8 @@ static void idetape_get_mode_sense_results (ide_drive_t *drive) > printk(KERN_INFO "ide-tape: Supports 32768 bytes block size / Restricted byte count for PIO transfers - %s\n",capabilities->blk32768 ? "Yes":"No"); > printk(KERN_INFO "ide-tape: Maximum supported speed in KBps - %d\n",capabilities->max_speed); > printk(KERN_INFO "ide-tape: Continuous transfer limits in blocks - %d\n",capabilities->ctl); > - printk(KERN_INFO "ide-tape: Current speed in KBps - %d\n",capabilities->speed); > + printk(KERN_INFO "ide-tape: Current speed in KBps - %d\n", > + capabilities->speed); > printk(KERN_INFO "ide-tape: Buffer size - %d\n",capabilities->buffer_size*512); > #endif /* IDETAPE_DEBUG_INFO */ > } this code goes away in patch #5 so I dropped this chunk [...] > @@ -4003,10 +3994,9 @@ static void idetape_get_blocksize_from_block_descriptor(ide_drive_t *drive) > } > return; > } > - header = (idetape_mode_parameter_header_t *) pc.buffer; > - block_descrp = (idetape_parameter_block_descriptor_t *) (pc.buffer + sizeof(idetape_mode_parameter_header_t)); > + block_descrp = (idetape_parameter_block_descriptor_t *) pc.buffer + 4; these brackets _are_ needed [ block_descrp is of 'idetape_parameter_block_descriptor_t *' type so without brackets +4 would mean + 4 * sizeof(idetape_parameter_block_descriptor_t) ] - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
