Re: [PATCH 13/14] sata_mv No soft resets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mark Lord wrote:
sata_mv No soft resets.

Soft resets rarely have significant effect with these chips,
so always do a hard reset instead.

Signed-off-by: Mark Lord <mlord@xxxxxxxxx>

--- old/drivers/ata/sata_mv.c    2008-01-24 14:49:28.000000000 -0500
+++ new/drivers/ata/sata_mv.c    2008-01-24 14:51:53.000000000 -0500
@@ -2414,8 +2414,7 @@

static void mv_error_handler(struct ata_port *ap)
{
-    ata_do_eh(ap, mv_prereset, ata_std_softreset,
-          mv_hardreset, mv_postreset);
+    ata_do_eh(ap, mv_prereset, NULL, mv_hardreset, mv_postreset);
}

Can you give a bit more explanation?

In general I agree, but SRST delivery does seem to work as intended from a device perspective, so I would like to narrow down the conditions where SRST must be avoided


-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux