On 1/16/08, Jeff Garzik <jeff@xxxxxxxxxx> wrote:
> saeed bishara wrote:
> > - if (unlikely(irq_stat & PCI_ERR)) {
> > + if (unlikely(irq_stat & PCI_ERR) && HAS_PCI(host)) {
> > mv_pci_error(host, mmio);
> > handled = 1;
> > goto out_unlock; /* skip all other HC irq handling */
>
> the unlikely() should cover the entire expression.
this will be applied into the new patch
>
>
>
> > static int __init mv_init(void)
> > {
> > - return pci_register_driver(&mv_pci_driver);
> > + int rc;
> > +#ifdef CONFIG_PCI
> > + rc = pci_register_driver(&mv_pci_driver);
> > + if (rc)
> > + return rc;
> > +#endif
> > + return 0;
> > }
>
> I would do
>
> {
> int rc = -ENODEV;
>
> #ifdef CONFIG_PCI
> rc = pci_register_driver(...);
> #endif
>
> return rc;
> }
ditto
>
> to ensure sane non-SoC, non-PCI behavior (which this patch now enables).
>
> Finally, in Kconfig, even when removing the CONFIG_PCI dependency, the
> driver suddenly has other unsatified dependencies: CONFIG_HAS_DMA and
> CONFIG_HAS_IOMEM. Those two need to be added to the Kconfig dep list.
but ATA is already depends on HAS_IOMEM! so it's not needed by the
driver's entry.
>
> I would have made these minor corrections myself, but git-am (main
> kernel patch-apply tool, for git users) doesn't seem to like the patch:
>
> Applying sata_mv: Remove PCI dependency
>
> fatal: corrupt patch at line 59
I attached the new patch
Attachment:
0001-sata_mv-Remove-PCI-dependency.patch
Description: Binary data
