I'm sorry, I should have guessed !! (I applied those little change to my code manually and then to the patch :) Thanks, George -----Original Message----- From: Bartlomiej Zolnierkiewicz [mailto:bzolnier@xxxxxxxxx] Sent: Thursday, January 10, 2008 2:26 AM To: George Kibardin Cc: linux-ide@xxxxxxxxxxxxxxx Subject: Re: 80 wire cable detection patch Hi, On Sunday 06 January 2008, George Kibardin wrote: > Signed-off-by: George Kibardin <george-kibardin@xxxxxxxxx> > > --- drivers/ide/ide-iops.c.orig 2008-01-03 18:35:23.000000000 +0300 > +++ drivers/ide/ide-iops.c 2008-01-03 18:12:29.000000000 +0300 > @@ -612,12 +612,12 @@ > printk(KERN_DEBUG "%s: skipping word 93 validity check\n", > drive->name); > > - if (hwif->cbl != ATA_CBL_PATA80 && !ivb) > - goto no_80w; > - > if (ide_dev_is_sata(id) && !ivb) > return 1; Ehm, this was not changed in the code before generating patch but in the patch itself so the patch won't apply... :( > + if (hwif->cbl != ATA_CBL_PATA80 && !ivb) > + goto no_80w; > + > /* > * FIXME: > * - change master/slave IDENTIFY order This time I just applied fix by hand and added missing patch summary ("ide: fix cable detection for SATA bridges") but in the future please make sure that the patch applies and has a meaningful description. Thanks, Bart - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
