Tejun Heo wrote:
Robert Hancock wrote:
Mark Lord wrote:
Tejun Heo wrote:
Hello, guys.
We still have three problems with ADMA.
* hard lockup during resume * occasional hard lockup after
hotplug or other erros (probably related to the above?)
This has only been reported on one person's MSI board. Apparently
another revision of the same board is reported to work, and I can't
duplicate the problem on my Asus board, so it could just be some
hardware problem on that motherboard.
IIRC, I have two from suse bug reports and both resolved with adma=0.
I'm not too sure whether post 2.6.23-rcX changes would have fixed those
problems tho. FWIW, I've disabled ADMA mode on all suse products.
A hotplug-related problem? Have a link to the reports?
I still can't say I'm really in favor of it.. In particular to do so
for 2.6.24 right now seems excessive, as none of these problems are
regressions from 2.6.23, and these controllers haven't been tested in
non-ADMA mode very much since it was made the default, so that change
might actually cause regressions.
Technically, they're regressions from pre-ADMA days - pretty grave ones
considering some of the failure modes include hard lock up. Also, they
don't seem resolvable in foreseeable future at this point. If this
isn't gonna improve, I think we should just drop ADMA support altogether
and concentrate on stabilizing non-ADMA operation. Stability is far
more important than small performance improvements or feature supports.
The suspend/resume problem should be resolvable. It worked before and
should be able to work again. Hopefully debug output with console
enabled during resume may provide some hints..
The cache flush timeout problem is a bit onerous, but hopefully we can
figure something out there with some more debugging by the reporter.
But, yeah, you're right in that the change might cause more problems.
What's your estimation of such possibility? I generally feel good about
non-ADMA mode operation as they seem to solve most reported sata_nv bugs
but I haven't really followed sata_nv code changes recently.
It's hard to say what may come up if we do this. I seem to recall that
there were some reports of wierd hotplug issues and high latencies on
register access that went away with ADMA mode.
I do think it's likely too late in the -rc series to make such a change
though. Hopefully by 2.6.25 we'll either have the issues fixed or have
more of an idea whether they can be.
Maybe this can be resolved by going through one more -rc cycle after the
change if that's possible.
Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
