On Sat, Jan 05, 2008 at 04:46:05PM +0100, Bartlomiej Zolnierkiewicz wrote:
> Hmm, no. The driver is called ide-floppy (ide_floppy) and it is more
> readable this way.
>
> > {
> > idefloppy_t *floppy = drive->driver_data;
> > struct gendisk *g = floppy->disk;
> > @@ -1479,7 +1450,7 @@ static ide_proc_entry_t idefloppy_proc[] = {
> > };
> > #endif /* CONFIG_IDE_PROC_FS */
> >
> > -static int ide_floppy_probe(ide_drive_t *);
> > +static int idefloppy_probe(ide_drive_t *);
>
> ditto
>
> [...]
>
> > @@ -1733,7 +1704,7 @@ static struct block_device_operations idefloppy_ops = {
> > .revalidate_disk= idefloppy_revalidate_disk
> > };
> >
> > -static int ide_floppy_probe(ide_drive_t *drive)
> > +static int idefloppy_probe(ide_drive_t *drive)
>
> ditto
Shouldn't those also conform to the driver function format idefloppy_bla() -
after all, those function names are unambiguous for the whole file...?
--
Regards/Gruß,
Boris.
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
