Alan Cox wrote:
> Signed-off-by: Alan Cox <alan@xxxxxxxxxx>
The comment is misleading at best...
It doesn't matter if NO_IRQ is zero or not here, because ata_irq
is not a static/global variable, but a local one. By removing the
initializer, here, the semantics changes.
But in this very case, it's safe to remove the initializer,
because this variable gets initialized a few lines below this
code snipped, in:
ata_irq = irq_of_parse_and_map(op->node, 0);
(and there's no other goto's before that, either).
/mjt
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc6-mm1/drivers/ata/pata_mpc52xx.c linux-2.6.24-rc6-mm1/drivers/ata/pata_mpc52xx.c
> --- linux.vanilla-2.6.24-rc6-mm1/drivers/ata/pata_mpc52xx.c 2008-01-02 16:03:58.000000000 +0000
> +++ linux-2.6.24-rc6-mm1/drivers/ata/pata_mpc52xx.c 2008-01-02 16:13:08.000000000 +0000
> @@ -364,7 +364,7 @@
> {
> unsigned int ipb_freq;
> struct resource res_mem;
> - int ata_irq = NO_IRQ;
> + int ata_irq;
> struct mpc52xx_ata __iomem *ata_regs;
> struct mpc52xx_ata_priv *priv;
> int rv;
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
