Alan Cox wrote: >> This patch implement ATAPI per-command-type DMA horkages and EH logic >> to set those quickly. This way, failures localized to certain command >> type don't affect other operations (most importantly READs) and >> working configuration is found quickly such that the device can be >> used. > > Seems sensible to treat them differently for different controllers. Have > you considered re-issuing failing ATAPI DMA commands as PIO as an EH > response ? I think determining whether to retry or not belongs to upper layer. Retrying random command can result in unexpected behavior. For things like device/media readiness testing, SCSI / cdrom layer will retry. For pass-through commands, I think it's better to leave it to the application. Thanks. -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
